Align resolve function names to have similiar namings#471
Closed
woehrl01 wants to merge 2 commits intofacebook:masterfrom
Closed
Align resolve function names to have similiar namings#471woehrl01 wants to merge 2 commits intofacebook:masterfrom
woehrl01 wants to merge 2 commits intofacebook:masterfrom
Conversation
Contributor
|
Thanks for improving the code quality! |
Contributor
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 10, 2017
Summary: We have some resolve functions with ```YG**Resolve``` and others named ```YGResolve**```. This changes both to be named like the later one, as I think this is the grammatically better readable one. Closes facebook/yoga#471 Differential Revision: D4688997 Pulled By: emilsjolander fbshipit-source-id: 38b5f84d4d39ed3effedf08188085b9efd96b4ce
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
Summary: We have some resolve functions with ```YG**Resolve``` and others named ```YGResolve**```. This changes both to be named like the later one, as I think this is the grammatically better readable one. Closes facebook/yoga#471 Differential Revision: D4688997 Pulled By: emilsjolander fbshipit-source-id: 38b5f84d4d39ed3effedf08188085b9efd96b4ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some resolve functions with
YG**Resolveand others namedYGResolve**. This changes both to be named like the later one, as I think this is the grammatically better readable one.